[5.4] Call getKey() if instance of factory model #18499
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've seen a few examples where a closure is used in a factory definition to build up a related model, and then return that new model's ID. Here's an example of how a
Post
factory might generate it'sUser
association.Getting the
id
attribute from the new model doesn't really look quite right, so I'm proposing we callgetKey()
on the result of theClosure
if it's an Eloquent model. Would just make it a tad cleaner to write.