-
Notifications
You must be signed in to change notification settings - Fork 11k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.4] Fluent partial resource routes #18393
Closed
Closed
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
2007105
add lazy registering resources tests
3afbd77
return PendingResourceRegistration when
4254df3
add method to remove existing routes
48336ab
register resource routes immediately
fb6afbb
refactor
713483d
fix route removing undefined index
b5d3ccf
Revert "fix route removing undefined index"
jaripekkala 1b1a468
Revert "refactor"
jaripekkala 99d6c88
Revert "register resource routes immediately"
jaripekkala 9618dc3
Revert "add method to remove existing routes"
jaripekkala b5459be
rename destruct to register,
jaripekkala a6a5015
rename lazy to registration, forget remember metho
jaripekkala f0067ef
resource method now PendingResourceRegistration
jaripekkala b797811
hold the resources pending until needed
jaripekkala 463d251
don't hold the prefixed resources
jaripekkala 1048ce7
testCanNotLimitMethodsAfterRegistered
jaripekkala File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,67 @@ | ||
<?php | ||
|
||
namespace Illuminate\Routing; | ||
|
||
class PendingResourceRegistration | ||
{ | ||
/** | ||
* The resource registrar. | ||
* | ||
* @var \Illuminate\Routing\ResourceRegistrar | ||
*/ | ||
protected $registrar; | ||
|
||
/** | ||
* The resource information. | ||
* | ||
* @var array | ||
*/ | ||
protected $resource; | ||
|
||
/** | ||
* Create a new pending resource registration instance. | ||
* | ||
* @param \Illuminate\Routing\ResourceRegistrar $registrar | ||
* @param array $resource | ||
* @return void | ||
*/ | ||
public function __construct(ResourceRegistrar $registrar, array $resource) | ||
{ | ||
$this->registrar = $registrar; | ||
$this->resource = $resource; | ||
} | ||
|
||
/** | ||
* Route a resource to a controller. | ||
* | ||
* @return void | ||
*/ | ||
public function register() | ||
{ | ||
$this->registrar->register( | ||
$this->resource['name'], | ||
$this->resource['controller'], | ||
$this->resource['options'] | ||
); | ||
} | ||
|
||
/** | ||
* Set the methods the controller should apply to. | ||
* | ||
* @param array|string|dynamic $methods | ||
*/ | ||
public function only($methods) | ||
{ | ||
$this->resource['options']['only'] = is_array($methods) ? $methods : func_get_args(); | ||
} | ||
|
||
/** | ||
* Set the methods the controller should exclude. | ||
* | ||
* @param array|string|dynamic $methods | ||
*/ | ||
public function except($methods) | ||
{ | ||
$this->resource['options']['except'] = is_array($methods) ? $methods : func_get_args(); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this PR should target 5.5, because this is a breaking change to the interface, requiring implementations to return this object
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A newbie question: does this require any actions by me? My first PR 🥇