Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.4] Removes unwanted dependency of illuminate/mail #18290

Merged
merged 4 commits into from
Mar 9, 2017
Merged

[5.4] Removes unwanted dependency of illuminate/mail #18290

merged 4 commits into from
Mar 9, 2017

Conversation

nunomaduro
Copy link
Member

@nunomaduro nunomaduro commented Mar 9, 2017

On the MailServiceProvider the method registerMarkdownRenderer is using the helper function config() on the following code:

        $this->app->singleton(Markdown::class, function () {
            return new Markdown($this->app->make('view'), [
                'theme' => config('mail.markdown.theme', 'default'),
                'paths' => config('mail.markdown.paths', []),
            ]);
        });

Problem: On the composer.json of the package illuminate/mail the package illuminate/foundation don't exists. So the helper function config() also don't exists.

Solucion: Makes usage of the app container to get the markdown app config.

@nunomaduro nunomaduro changed the title Removes unwanted dependency of illuminate/mail [ 5.4 ]Removes unwanted dependency of illuminate/mail Mar 9, 2017
@nunomaduro nunomaduro changed the title [ 5.4 ]Removes unwanted dependency of illuminate/mail [5.4] Removes unwanted dependency of illuminate/mail Mar 9, 2017
@taylorotwell taylorotwell merged commit 2f7cf24 into laravel:5.4 Mar 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants