[5.4] @lang directive is not working with json lang file #17919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrahamCampbell
changed the title
|
Use the trans directive. |
|
Hey @taylorotwell there is no trans directive in Laravel5.4 I do not see that directive in documentation or in any part of the code. I have only seen this directive at laravel-news post which was written by @themsaid . I also confirm that trans directive not working (because there is not trans directive I think) on my Laravel5.4.11 installation. |
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@lang Blade directive is not working. This PR tries to adjust @lang directive with new "getFromJson" method. If json is not set then "get" method will be called as fallback.