Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.5] Configurability of local key when using a BelongsToMany relationship #17903

Merged
merged 3 commits into from
Feb 13, 2017
Merged

[5.5] Configurability of local key when using a BelongsToMany relationship #17903

merged 3 commits into from
Feb 13, 2017

Conversation

alberto-bottarini
Copy link
Contributor

This PR implements this proposal laravel/ideas#406

@taylorotwell taylorotwell merged commit b900c41 into laravel:master Feb 13, 2017
@taylorotwell
Copy link
Member

Added missing doc blocks, etc.

@Garbee
Copy link
Contributor

Garbee commented May 3, 2017

Why was the new localkey not added as the final parameter to not break upgrading?

@alberto-bottarini
Copy link
Contributor Author

Because relationName is the only optional parameter in BelongsToMany constructor.

https://github.com/laravel/framework/blob/master/src/Illuminate/Database/Eloquent/Relations/BelongsToMany.php

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants