Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.4] test both phpredis and predis drivers #17481

Closed
wants to merge 1 commit into from
Closed

[5.4] test both phpredis and predis drivers #17481

wants to merge 1 commit into from

Conversation

halaei
Copy link
Contributor

@halaei halaei commented Jan 22, 2017

Tests should fail because now because of my bad PR #17477

Sorry :(

@taylorotwell
Copy link
Member

I've reverted 2 of the PRs.

@GrahamCampbell
Copy link
Member

Please rebase this. :)

@taylorotwell
Copy link
Member

I may just merge #17196 to normalize all this.

@halaei
Copy link
Contributor Author

halaei commented Jan 22, 2017

@GrahamCampbell you mean I should resubmit this?

@halaei halaei mentioned this pull request Jan 22, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@halaei @taylorotwell @GrahamCampbell