Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.4] Use ::class notation #17357

Merged
merged 1 commit into from
Jan 17, 2017
Merged

[5.4] Use ::class notation #17357

merged 1 commit into from
Jan 17, 2017

Conversation

lucasmichot
Copy link
Contributor

@lucasmichot lucasmichot commented Jan 16, 2017 •
edited
Loading

Use ::class notation.

Notes:

  • This PR only apply to /src code.
  • Some FQN were let as it on purpose.
  • This PR should probably be passed just before 5.4 first release.

@GrahamCampbell
Copy link
Member

Not sure it makes sense to make this change for little merit.

@lucasmichot
Copy link
Contributor Author

lucasmichot commented Jan 16, 2017 •
edited
Loading

It's more about consistency, as for #17148 by @alexbowers.
Not sure this PR will be merged though.

I let it open as WIP to include some other commits if necessary, up to Taylor to merge it just before 5.4 release if he feels so.

@alexbowers
Copy link
Contributor

@GrahamCampbell Just my 2¢; but the ability to click through on an IDE to a class (which ::class allows but, but a string doesn't), is quite useful.

I'd very much like it to be a standard part going forward if possible.

@TommyC81
Copy link

What @alexbowers said, anything that lets us take advantage of external functionality is helpful.

@taylorotwell taylorotwell merged commit b282a1d into laravel:5.4 Jan 17, 2017
@lucasmichot lucasmichot deleted the feature/5.4/class-notation branch January 17, 2017 14:21
@tillkruss tillkruss changed the title [5.4] [WIP] Use ::class notation [5.4] Use ::class notation Jan 20, 2017
@lucasmichot lucasmichot mentioned this pull request Jan 24, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lucasmichot @GrahamCampbell @alexbowers @TommyC81 @taylorotwell