Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.4] Macro on Schedule #17107

Merged
merged 2 commits into from
Jan 3, 2017
Merged

[5.4] Macro on Schedule #17107

merged 2 commits into from
Jan 3, 2017

Conversation

alexbowers
Copy link
Contributor

No description provided.

@alexbowers
Copy link
Contributor Author

Instead of #17084

@alexbowers alexbowers changed the title Macro [5.4] Macro on Schedule Jan 3, 2017
lucasmichot
lucasmichot reviewed Jan 3, 2017
View reviewed changes
src/Illuminate/Console/Scheduling/Event.php
use Illuminate\Contracts\Container\Container;
use Illuminate\Contracts\Cache\Repository as Cache;

class Event
{
use Macroable;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be use Macroable, ManagesFrequencies;

@taylorotwell taylorotwell merged commit d9b5382 into laravel:5.4 Jan 3, 2017
@alexbowers alexbowers deleted the feature/schedule-macro branch January 3, 2017 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucasmichot lucasmichot lucasmichot left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexbowers @lucasmichot @taylorotwell