Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.4] Unused argument is removed #17071

Merged
merged 1 commit into from
Jan 2, 2017
Merged

[5.4] Unused argument is removed #17071

merged 1 commit into from
Jan 2, 2017

Conversation

neyaoz
Copy link
Contributor

@neyaoz neyaoz commented Jan 1, 2017

Container@make is not accepting $parameters argument anymore.

The make() method no longer accepts a second argument of parameters - needing this feature indicates a code smell and you can always construct the object in another way.

ff993b8#diff-51bfc610692c3ed3388dec0ec04bd3baL116

@GrahamCampbell GrahamCampbell changed the title Unused argument is removed. [5.4] Unused argument is removed Jan 1, 2017
@taylorotwell taylorotwell merged commit fb0d4bd into laravel:5.4 Jan 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants