[5.4] Support column alias in Eloquent chunkById #17034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Furthermore, the $column param is now optional, defaulting to the model's key.
riesjart
changed the title
vlakoff
reviewed
Jan 5, 2017
| @@ -425,10 +425,15 @@ public function chunk($count, callable $callback) | |||
| * @param int $count | |||
| * @param callable $callback | |||
| * @param string $column | |||
| * @param string|null $alias | |||
There was a problem hiding this comment.
It should be string|null for $column too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up on #14711, for the same method in the Eloquent builder. Furthermore, the $column param is now optional, defaulting to the model's key.