Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.4] Method to return array of namespace hints. #16664

Merged
merged 1 commit into from
Dec 7, 2016
Merged

[5.4] Method to return array of namespace hints. #16664

merged 1 commit into from
Dec 7, 2016

Conversation

grinry
Copy link
Contributor

@grinry grinry commented Dec 5, 2016

No description provided.

@taylorotwell
Copy link
Member

Remove the change to gitignore file please.

@grinry
Copy link
Contributor Author

grinry commented Dec 6, 2016

Done. But what is the reason you dont want to ignore idea settings?

@taylorotwell
Copy link
Member

You should add that to your Git global ignores.

/phpunit.xml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be no changes to this file at all in this PR.

@GrahamCampbell GrahamCampbell changed the title [5.4] (Translations) Method to return array of namespace hints. [5.4] Method to return array of namespace hints. Dec 7, 2016
@grinry grinry closed this Dec 7, 2016
@grinry grinry reopened this Dec 7, 2016
@taylorotwell taylorotwell merged commit 207694e into laravel:master Dec 7, 2016
@grinry grinry deleted the patch-2 branch December 9, 2016 18:03
@tillkruss
Copy link
Contributor

@kiberzauras: What does this do?

@grinry
Copy link
Contributor Author

grinry commented Dec 13, 2016

@tillkruss packages can have translations, and translations of these packages should have hints, for example if we use trans('vendor::validation.required'); it will try to get translation of package named vendor.

Now in this commits i just added method, which retrieves array of already registered hints, since they was protected. This will be great help for translation manager packages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants