[5.4] Remove duplicated test for __call() #16346
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There wasn't any modification of the `__call` method with the `HigherOrderCollectionMapFromArrays` addition, so we don't need to test it again.
mathieutu
changed the title
|
👎 Just because a test executes the same code, it doesn't make it a duplicate. This tests uppercasing works. Think about it as a blackbox test. |
|
Yeah but this is doing exactly the same thing and this doesn't test at all the new feature: the method is about testing an array, theses lines test the behavior of an object. We can't really talk about perfs here but for me it's just dead code. It's as you want, it was just to remove a (in my mind) useless copy/paste. |
|
I don't see this as a duplicated test. There is behavior that could regress if this test was removed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There wasn't any modification of the
__callmethod with theHigherOrderCollectionMapFromArraysaddition (#16274), so we don't need to test it again.In my mind the removed test was just a vestige of a copy/paste.