[5.4] Add cache forget command and use it in the event Schedule #16201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taylorotwell
reviewed
Nov 1, 2016
|
|
||
| $this->phpBinary = ProcessUtils::escapeArgument((new PhpExecutableFinder)->find(false)); | ||
|
|
||
| $this->artisan = defined('ARTISAN_BINARY') ? ProcessUtils::escapeArgument(ARTISAN_BINARY) : 'artisan'; |
There was a problem hiding this comment.
I think it would be better to extract this to some static method on a class or something that way we don't have to do all this just to pass a command name into the event class.
There was a problem hiding this comment.
To me it seems like we should be able to call like Something('cache:forget') and receive back a fully formatted call to php artisan cache:forget.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of forgetting the cache key directly after running the command (which can be run in the background), we use a
cache:forgetconsole command that'll run after our command runs, this ensure the cache is cleared after the command actually finished running.