[5.3] Keep files in the $data array after hydration #16104
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's say we have this validator instance:
When
hydrateFiles()
is called$validator->data
will be empty, and$validator->files
will look like:So when the required rule runs, it expects a
files
key to be present, but that key was removed during hydration so the rule will fail although there are files present in the Validator instance.This PR prevents removing the files from
$validator->data
which will make such rule pass.In 5.4 we removed the hydration step entirely.