Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.4] Make the log facade use the interface #15855

Merged
merged 1 commit into from
Oct 11, 2016
Merged

[5.4] Make the log facade use the interface #15855

merged 1 commit into from
Oct 11, 2016

Conversation

GrahamCampbell
Copy link
Member

No description provided.

@GrahamCampbell GrahamCampbell mentioned this pull request Oct 11, 2016
Closed
@taylorotwell taylorotwell merged commit 2559728 into master Oct 11, 2016
@GrahamCampbell GrahamCampbell deleted the log-facade branch October 11, 2016 21:50
@antonkomarev
Copy link
Contributor

@GrahamCampbell sorry for raising this question here, but is there any reason why string used instead of:

return \Psr\Log\LoggerInterface::class;

@GrahamCampbell
Copy link
Member Author

We haven't done that in any of the other facades.

@GrahamCampbell GrahamCampbell mentioned this pull request Mar 9, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GrahamCampbell @antonkomarev @taylorotwell