[5.3] Add model methods only and except #15748
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taylorotwell
reviewed
Oct 5, 2016
| foreach ($keys as $key) { | ||
| $value = $this->getAttribute($key); | ||
|
|
||
| if (! is_null($value)) { |
There was a problem hiding this comment.
This might be a little problematic if the database value is actually null.
There was a problem hiding this comment.
Why not just use Arr::only like you do for except?
There was a problem hiding this comment.
Good point. Don't know why I did that. Will update
|
Going to hold off on this since I feel like you could just do Arr::only($model->toArray()... manually. |
|
Fair enough! Thanks for taking the time to review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feels like
exceptmight be a bit inefficient because it will load relations even if they are "ignored". Any ideas on how to improve it without replicatingattributesToArray?