[5.3] Fire an event while running a console command

[themsaid]

This PR fires a CommandRunning event before executing a console command.

As reported in #15610, laravel doesn't set Symfony's dispatcher while running console commands which causes Symfony's own console events not to fire.

Laravel already fires a ArtisanStarting command on Artisan start, but it doesn't contain information about the command running or the inputs given, this new event will get fired before running every console command allowing tasks like logging, sending notifications, etc...

[taylorotwell]

Hmm, I'm curious of the use case for this.

[themsaid]

I can only think of logging, if you need to keep track of when a command was run.

[mcklayin]

Some guy from stackoverflow need it. He want to fire some function, when every console command was executed, but now its impossible, php artisan --help fires event too, and he need only comands like php artisan some_command_name

[lucasmichot]

After getting the parent $exitCode, a \Illuminate\Console\Events\CommandHasRun event would be useful too.

[taylorotwell]

Useful for what though? We haven't even clearly identified a use case for the first event? Other than some person on StackOverflow wanted it for apparently something :)

[lucasmichot]

After getting the parent $exitCode, a \Illuminate\Console\Events\CommandHasRun event would be useful too.

This would allow to run "chained" commands very easily, upon success or another command in case of a failure (based on the command name, input and/or $exitCode).

// ...
$exitCode = parent::run($input, $output);

$this->events->fire(
    new Events\CommandHasRun($this->getCommandName($input), $input, $exitCode)
);

return $exitCode;

[themsaid]

@taylorotwell Well in my last project we had some reset console commands we used to reset client data after their demo and training before they start using the software. These commands are dangerous so we logged every attempt of using it in case we found any missing data in the DB.

The developer can always do the logging inside the command itself, I just checked the issue on this repo and saw that Symfony fires a similar event, and also laravel fires an event on Artisan start so thought it might maybe useful to have such event.

Anyway the use case is very very limited, so I guess we can close this PR :)

[taylorotwell]

Going to hold off on this for now since I don't feel like we have a real solid use case at the moment.

[bmitch]

Any chance this could be looked at again? We have a use case where we schedule multiple commands to run each night and would like to log messages when the command has started and finished.

Would be great if there were events for when a command has started and finished. Then could latch onto those events and Log a message that the command has started and finished.

Then easy enough to see logs if each command completed.

We could write these logs in each command independently but thought by using events like this, could write them in just one place.

[ajthinking]

I have a use case for this feature: After any artisan migrate command, I would like to run a custom script to manage triggers and functions in my database extension. I really dont want to modify or duplicate the existing migrate command. This would also break all my third party stuff. I just want to do some stuff right after artisan migrate.