[5.3] Optimize Arr methods #15278
[5.3] Optimize Arr methods #15278
Conversation
| @@ -120,7 +120,7 @@ public static function exists($array, $key) | |||
| return $array->offsetExists($key); | |||
| } | |||
|
|
|||
| return array_key_exists($key, $array); | |||
| return isset($array[$key]) || array_key_exists($key, $array); | |||
There was a problem hiding this comment.
array_key_exists is pretty much the same speed on php 7, so you've actually made this slower
There was a problem hiding this comment.
…and even if it's slower, the difference is super micro and just not worth it if I may add. Unless, of course, you're calling this method repeatedly for like 10,000 times.
There was a problem hiding this comment.
Even then, you're making this twice as slow for cases where it is there and is null.
There was a problem hiding this comment.
There's a benchmark example in php.net
Benchmark (100000 runs):
array_key_exists() : 205 ms
isset() : 35ms
isset() || array_key_exists() : 48ms
However if you are running this 100000 times i guess that 157ms is not your main concern.
So indeed it's not worth it.
Also this is an old benchmark so array_key_exists on PHP7 and 5.6 should be faster.
There was a problem hiding this comment.
I only test this on local machine, and adding isset is faster.
However, when using sandbox online, array_key_exists is faster.
Benchmark : http://sandbox.onlinephpfunctions.com/code/90069414dc1b46c666fbfd96e1b9415b9d151378
|
Holding off on this for now because there are no benchmarks to prove the optimizations are relevant. |
|
Benchmarks: Arr::forget: http://sandbox.onlinephpfunctions.com/code/161e998b5eadba07d9b76feb61c629e8142176d6 Arr::set: http://sandbox.onlinephpfunctions.com/code/324e9cdb0d9c6662ceb30a1db534fd1e0fd206e9 forget, set are original and _forget, _set are optimized @taylorotwell , except the Arr::exists, should i create a new pr? |
Using isset to optimize the process, only if the value is null will use array_key_exists to determine the given key exists.
Same as #15213, prevent array copy.
Use foreach to prevent multiple array_shift.