Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix method names inversion in Blade compiler. #1112

Closed
wants to merge 1 commit into from
Closed

Fix method names inversion in Blade compiler. #1112

wants to merge 1 commit into from

Conversation

vlakoff
Copy link
Contributor

@vlakoff vlakoff commented Apr 30, 2013

Introduced in d08afd0.

@vlakoff
Copy link
Contributor Author

vlakoff commented Apr 30, 2013

Tests failed, had a quick look but didn't find out, will dig into it later.

@taylorotwell
Copy link
Member

It doesn't look like they "failed" but rather Travis "error"'d, which it seems to do on about 75% of our builds for some reason.

@taylorotwell
Copy link
Member

Oh, nevermind, they did fail. :)

@vlakoff
Copy link
Contributor Author

vlakoff commented Apr 30, 2013

Thanks for fixing. Understood the problem with overlapping regexes, I wish I could provide a robuster solution.

rentalhost added a commit to rentalhost/framework that referenced this pull request Feb 16, 2020
rentalhost added a commit to rentalhost/framework that referenced this pull request Feb 16, 2020
rentalhost added a commit to rentalhost/framework that referenced this pull request Feb 17, 2020
rentalhost added a commit to rentalhost/framework that referenced this pull request Feb 17, 2020
taylorotwell pushed a commit that referenced this pull request Feb 18, 2020
…$sql, array $bindings = []) [fixes #1112]. (#31498)

* Illuminate\Database\Query\Builder: added support to groupByRaw($sql, array $bindings = []) [fixes #1112].

* Update Builder.php

* Update Builder.php

* Update Builder.php

Co-authored-by: Graham Campbell <[email protected]>
gonzalom pushed a commit to Hydrane/tmp-laravel-framework that referenced this pull request Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants