Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unsupported use of @php? #22621

Closed
collegeman opened this issue Jan 3, 2018 · 7 comments
Closed

Unsupported use of @php? #22621

collegeman opened this issue Jan 3, 2018 · 7 comments

Comments

@collegeman
Copy link
Contributor

In my exploration of the Sage WordPress Starter Theme—a WordPress project that borrows much from Laravel, including introducing Blade as a dependency—I have found an interesting problem. I'm reporting it as a bug instead of a pull request only because I can't think of an easy way to solve the problem, and I'm hoping the community might.

The problem arises from the following (potentially unsupported use case) of the @php directive. Consider the following script:

<html @php(language_attributes())>
<head>
  <title>
    @php
       $someArbitraryThing = 'whatever';
       echo $someArbitraryThing;
    @endphp
  </title>
</head>
<body></body>
</html>

When compiling the above, the Blade engine produces something like the following:

<html <?php(language_attributes())>
<head>
  <title>
    @php
       $someArbitraryThing = 'whatever';
       echo $someArbitraryThing;
    @endphp
  </title>
</head>
<body></body>
</html>

Instead of what was expected, e.g.,

<html <?php (language_attributes()); ?>>
<head>
  <title>
    <?php $someArbitraryThing = 'whatever';
       echo $someArbitraryThing;
     ?>
  </title>
</head>
<body></body>
</html>

I have discovered that this is caused by the regular expression in BladeCompiler::storePhpBlocks, which is used to collect all of the template content inside each section of @php to @endphp, including sections that span multiple lines of the template.

So the conflict seems to be that if one uses the single-tag form of the @php directive anywhere in a template, one cannot also use the open/close form of the @php directive anywhere thereafter in the same template.

It's entirely possible that @php shouldn't be used in a single-tag form—the Laravel documentation does not say it can be used this way, though it does work, so long as no @endphp appears in the same template. Maybe instead of this single-tag form, folks should simply use something like {!! functionCall() !!} instead?
@devcircus
Copy link
Contributor

According to the 5.5 upgrade guide, the inline syntax is no longer supported. See below:

@php Blade Directive
The @php blade directive no longer accepts inline tags. Instead, use the full form of the directive:

@php
    $teamMember = true;
@endphp

@mul14
Copy link
Contributor

mul14 commented Jan 3, 2018

I believe they change @php Blade directive behaviour because of this #20065

@collegeman
Copy link
Contributor Author

@devcircus, @mul14, and @GrahamCampbell: thank you all for the time you spent on this. It was exactly the confirmation I needed.

@collegeman collegeman mentioned this issue Jan 3, 2018
Closed
@cpouldev cpouldev mentioned this issue Mar 17, 2018
Merged
@ameenross
Copy link
Contributor

I found the mention of "inline tags" in the upgrade guide vague, so I googled it and landed here. So I tested this snippet, but it seems that the behavior changed again?

>>> Blade::compileString('@php(1+2+3) {{$bar}} @php(4+5)')
=> "<?php (1+2+3); ?> <?php echo e($bar); ?> <?php (4+5); ?>"

@ameenross
Copy link
Contributor

Also interesting:

>>> Blade::compileString('@php(echo"foo") @php(print"bar")')
=> "<?php (echo"foo"); ?> <?php (print"bar"); ?>"

Obviously the echo won't work, because it's a (PHP) language construct. However, print will work.

@ameenross
Copy link
Contributor

Ok, hold on. It seems the behavior wasn't changed, it's just unpredictable:

>>> Blade::compileString('@php(echo"foo") @php print"bar"; @endphp')
=> "<?php(echo"foo") @php print"bar"; ?>"

Apparently, when you have an @endphp in your code, no ?> will be added after the closing parentheses. So combining @php() with @php $expr + $ession; @endphp is problematic

sweber83 added a commit to sweber83/controller that referenced this issue Oct 23, 2019
@sweber83
remove usage of deprecated @php syntax from readme.md
fd9f164 
see laravel/framework#22621 for further information
@sweber83 sweber83 mentioned this issue Oct 23, 2019
Merged
@mirafzal
Copy link

mirafzal commented Oct 5, 2022 •
edited
Loading

regex replace:
@php((.*))
@php $1 @endphp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@mul14 @collegeman @ameenross @GrahamCampbell @devcircus @mirafzal