Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limited passing second param in orWhereRaw #18952

Closed
projct1 opened this issue Apr 26, 2017 · 2 comments
Closed

Limited passing second param in orWhereRaw #18952

projct1 opened this issue Apr 26, 2017 · 2 comments

Comments

@projct1
Copy link

projct1 commented Apr 26, 2017 •
edited
Loading

  • Laravel Version: 5.4.19

Description:

Why in method whereRaw second param is not strict array ($bindings = []), and in method orWhereRaw second param is strict array (array $bindings = [])?
@projct1 projct1 changed the title Limited passing variables in orWhereRaw Limited passing second param in orWhereRaw Apr 26, 2017
@ntzm
Copy link
Contributor

ntzm commented Apr 26, 2017

Feel free to submit a PR 😄

@u1735067
Copy link
Contributor

This is an actual bug, why was this closed ? o_O
Leading to

FatalThrowableError
Type error: Argument 2 passed to Illuminate\Database\Query\Builder::orWhereRaw() must be of the type array, string given

@u1735067 u1735067 mentioned this issue Jul 24, 2017
Merged
taylorotwell pushed a commit that referenced this issue Jul 25, 2017
@u1735067 @taylorotwell
Respect the signature of whereRaw, fix #18952 (#20234)
fab2e13 
Would lead to
```
FatalThrowableError
Type error: Argument 2 passed to Illuminate\Database\Query\Builder::orWhereRaw() must be of the type array, string given
```
otherwise.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@u1735067 @ntzm @themsaid @projct1