-
Notifications
You must be signed in to change notification settings - Fork 11k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filesystem URL creation for Local driver has a hardcoded path prefix #13364
Comments
This hardcoded path on the FileSystemAdapter actually returns a wrong value for the default config (default is Now in 5.3 there's a public driver and the code is even uglier (looking for public and replacing the occurence) source. I am not sure what the behaviour should be for |
Just ran into this problem myself testing generation of a file. I thought it would adhere to the configuration of the used disk but as you say, the prefix is hardcoded as you say. |
ATM I am using the much less convenient |
@j3j5 I'm doing similiary. Feels like a hack..
|
The |
I also had this issue 👍 |
this works for me: Storage::disk('local')->getDriver()->getAdapter()->getPathPrefix() |
This should be fixed here: #16281 |
Fetching URLs for local filesystem is conflicting with filesystem configuration option. I've specified where I want my files to be stored (public directory)
Code assuming that we always store in
storage
directory, no options to override it:(Source)
Perhaps it would be better if we could specify the prefix (not the full path) in config array, like, in a publicRoot field, or something like that.
The text was updated successfully, but these errors were encountered: