Filesystem URL creation for Local driver has a hardcoded path prefix

[briedis]

Fetching URLs for local filesystem is conflicting with filesystem configuration option. I've specified where I want my files to be stored (public directory)

'root' => public_path('my-storage-directory'),

Code assuming that we always store in storage directory, no options to override it:

} elseif ($adapter instanceof LocalAdapter) {
            return '/storage/'.$path;
} else {

(Source)

Perhaps it would be better if we could specify the prefix (not the full path) in config array, like, in a publicRoot field, or something like that.

[j3j5]

This hardcoded path on the FileSystemAdapter actually returns a wrong value for the default config (default is storage_path('app') and Storage::url() would omit the app).

Now in 5.3 there's a public driver and the code is even uglier (looking for public and replacing the occurence) source.

I am not sure what the behaviour should be for url() but right now it just returns wrong paths for the local driver with the default settings.

[thomassjogren]

Just ran into this problem myself testing generation of a file. I thought it would adhere to the configuration of the used disk but as you say, the prefix is hardcoded as you say.

[j3j5]

ATM I am using the much less convenient config('filesystems.disks.local.root') . DIRECTORY_SEPARATOR . $filename.

[briedis]

@j3j5 I'm doing similiary. Feels like a hack..

protected function getUrl()
    {
        /** @var Filesystem|FilesystemAdapter $storage*/
        $storage= \app('storage.images');

        $adapter = $storage->getAdapter();

        if ($adapter instanceof AwsS3Adapter) {
            return $storage->url($this->getFilePathname());
        }

        if ($adapter instanceof Local) {
            return url('uploads/images/' . $this->getFilePathname());
        }

        throw new \Exception('Unknown driver, can`t generate URL');
    }

[thomassjogren]

The LocalAdapter also have a getPathPrefix() method that returns the root set in the config, so I guess that should be used in the FilesystemAdapter.php.

[masonfox]

I also had this issue 👍

[stpangia]

this works for me:

Storage::disk('local')->getDriver()->getAdapter()->getPathPrefix()

[themsaid]

This should be fixed here: #16281