-
Notifications
You must be signed in to change notification settings - Fork 11k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
1 parent
dc68b3d
commit f17e347
Showing
3 changed files
with
25 additions
and
25 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,11 +1,11 @@ | ||
| <tr> | ||
| <td> | ||
| <table class="footer" align="center" width="570" cellpadding="0" cellspacing="0" role="presentation"> | ||
| <tr> | ||
| <td class="content-cell" align="center"> | ||
| {{ Illuminate\Mail\Markdown::parse($slot) }} | ||
| </td> | ||
| </tr> | ||
| </table> | ||
| </td> | ||
| <td> | ||
| <table class="footer" align="center" width="570" cellpadding="0" cellspacing="0" role="presentation"> | ||
| <tr> | ||
| <td class="content-cell" align="center"> | ||
| {{ Illuminate\Mail\Markdown::parse($slot) }} | ||
| </td> | ||
| </tr> | ||
| </table> | ||
| </td> | ||
| </tr> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,13 +1,13 @@ | ||
| <table class="panel" width="100%" cellpadding="0" cellspacing="0" role="presentation"> | ||
| <tr> | ||
| <td class="panel-content"> | ||
| <table width="100%" cellpadding="0" cellspacing="0" role="presentation"> | ||
| <tr> | ||
| <td class="panel-item"> | ||
| {{ Illuminate\Mail\Markdown::parse($slot) }} | ||
| </td> | ||
| </tr> | ||
| </table> | ||
| </td> | ||
| </tr> | ||
| <tr> | ||
| <td class="panel-content"> | ||
| <table width="100%" cellpadding="0" cellspacing="0" role="presentation"> | ||
| <tr> | ||
| <td class="panel-item"> | ||
| {{ Illuminate\Mail\Markdown::parse($slot) }} | ||
| </td> | ||
| </tr> | ||
| </table> | ||
| </td> | ||
| </tr> | ||
| </table> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,7 @@ | ||
| <table class="subcopy" width="100%" cellpadding="0" cellspacing="0" role="presentation"> | ||
| <tr> | ||
| <td> | ||
| {{ Illuminate\Mail\Markdown::parse($slot) }} | ||
| </td> | ||
| </tr> | ||
| <tr> | ||
| <td> | ||
| {{ Illuminate\Mail\Markdown::parse($slot) }} | ||
| </td> | ||
| </tr> | ||
| </table> |
f17e347There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why? 🌵
f17e347There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exactly....Why...?
f17e347There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There were some issues after we switched to CommonMark. We decided to remove the indentation here because the indentation was re-parsed sometimes for inherited views after being parsed by Markdown.
For more info see #31065
f17e347There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx for the info. Is it fair to say that this is not so much a fix of the problem as it is treating a symptom...? (Not saying it should/shouldn't be done....I'm just thinking that there may be problems going forward with "unindented" markup.)
f17e347There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@telkins we can't revert the PR because we had to switch parsers because the previous parser had an XSS vulnerability. Let's just see if any problems arise.
f17e347There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @driesvints,
I'm reporting an issue.
Previously, I exported the default template. After upgrading to Laravel 7, the panel component spits outs HTML in the email
f17e347There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please clear your view cache.
f17e347There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And did you republish the mail templates?
f17e347There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And if you exported them, you'll need to-export them and re-apply your changes.
f17e347There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cleared my view cache - nothing changes. The fix is to remove indentation or republish and apply changes. Really not ideal in my opinion.
f17e347There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AntoineAugusti add the
--forceoption.#31065 (comment)