[10.x] Arr::select not working when $keys is a string (#50169)

* Arr::select not working when $keys is a string Adding a check about $keys type. If it is a string, transform it into an array. If not, it throws a foreach() error * add test --------- Co-authored-by: Taylor Otwell <[email protected]>
laravel · Feb 21, 2024 · e708043 · e708043
1 parent abeec17
commit e708043
Show file tree

Hide file tree

Showing 2 changed files with 38 additions and 0 deletions.
diff --git a/src/Illuminate/Collections/Arr.php b/src/Illuminate/Collections/Arr.php
@@ -516,6 +516,8 @@ public static function only($array, $keys)
      */
     public static function select($array, $keys)
     {
+        $keys = static::wrap($keys);
+
         return static::map($array, function ($item) use ($keys) {
             $result = [];
 

diff --git a/tests/Support/SupportArrTest.php b/tests/Support/SupportArrTest.php
@@ -1273,4 +1273,40 @@ public function testTake()
             4, 5, 6,
         ], Arr::take($array, -3));
     }
+
+    public function testSelect()
+    {
+        $array = [
+            [
+                'name' => 'Taylor',
+                'role' => 'Developer',
+                'age' => 1,
+            ],
+            [
+                'name' => 'Abigail',
+                'role' => 'Infrastructure',
+                'age' => 2,
+            ],
+        ];
+
+        $this->assertEquals([
+            [
+                'name' => 'Taylor',
+                'age' => 1,
+            ],
+            [
+                'name' => 'Abigail',
+                'age' => 2,
+            ],
+        ], Arr::select($array, ['name', 'age']));
+
+        $this->assertEquals([
+            [
+                'name' => 'Taylor',
+            ],
+            [
+                'name' => 'Abigail',
+            ],
+        ], Arr::select($array, 'name'));
+    }
 }