[10.x] Fixes the Arr::dot() method to properly handle indexes array (…

…#49507) * Fixes the `Arr::dot()` method to properly handle arrays with integer keys * Update tests/Support/SupportArrTest.php Co-authored-by: Mior Muhammad Zaki <[email protected]> --------- Co-authored-by: Mior Muhammad Zaki <[email protected]>
laravel · Dec 28, 2023 · bd9b41e · bd9b41e
1 parent ac960a1
commit bd9b41e
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/src/Illuminate/Collections/Arr.php b/src/Illuminate/Collections/Arr.php
@@ -113,13 +113,13 @@ public static function dot($array, $prepend = '')
 
         foreach ($array as $key => $value) {
             if (is_array($value) && ! empty($value)) {
-                $results[] = static::dot($value, $prepend.$key.'.');
+                $results = array_merge($results, static::dot($value, $prepend.$key.'.'));
             } else {
-                $results[] = [$prepend.$key => $value];
+                $results[$prepend.$key] = $value;
             }
         }
 
-        return array_merge(...$results);
+        return $results;
     }
 
     /**

diff --git a/tests/Support/SupportArrTest.php b/tests/Support/SupportArrTest.php
@@ -102,6 +102,12 @@ public function testDot()
         $array = Arr::dot(['foo' => ['bar' => 'baz']]);
         $this->assertSame(['foo.bar' => 'baz'], $array);
 
+        $array = Arr::dot([10 => 100]);
+        $this->assertSame([10 => 100], $array);
+
+        $array = Arr::dot(['foo' => [10 => 100]]);
+        $this->assertSame(['foo.10' => 100], $array);
+
         $array = Arr::dot([]);
         $this->assertSame([], $array);