[11.x] Avoid using Laravel new error page if app.debug changes to `…

…true` at runtime (#51705)

* [11.x] Avoid using Laravel new renderer if `app.debug` changes to `true`
at runtime

Signed-off-by: Mior Muhammad Zaki <[email protected]>

* wip

Signed-off-by: Mior Muhammad Zaki <[email protected]>

---------

Signed-off-by: Mior Muhammad Zaki <[email protected]>

src/Illuminate/Foundation/Exceptions/Handler.php

@@ -833,9 +833,11 @@ protected function renderExceptionContent(Throwable $e)
     {
         try {
             if (config('app.debug')) {
-                return app()->has(ExceptionRenderer::class)
-                    ? $this->renderExceptionWithCustomRenderer($e)
-                    : $this->container->make(Renderer::class)->render(request(), $e);
+                if (app()->has(ExceptionRenderer::class)) {
+                    return $this->renderExceptionWithCustomRenderer($e);
+                } elseif ($this->container->bound(Renderer::class)) {
+                    return $this->container->make(Renderer::class)->render(request(), $e);
+                }
             }
 
             return $this->renderExceptionWithSymfony($e, config('app.debug'));

tests/Integration/Foundation/Exceptions/RendererTest.php

@@ -0,0 +1,40 @@
+<?php
+
+namespace Illuminate\Tests\Integration\Foundation\Exceptions;
+
+use Illuminate\Foundation\Exceptions\Renderer\Renderer;
+use Orchestra\Testbench\Attributes\WithConfig;
+use Orchestra\Testbench\TestCase;
+use RuntimeException;
+
+class RendererTest extends TestCase
+{
+    protected function defineRoutes($router)
+    {
+        $router->get('failed', fn () => throw new RuntimeException('Bad route!'));
+    }
+
+    #[WithConfig('app.debug', true)]
+    public function testItCanRenderExceptionPage()
+    {
+        $this->assertTrue($this->app->bound(Renderer::class));
+
+        $this->get('/failed')
+            ->assertInternalServerError()
+            ->assertSee('RuntimeException')
+            ->assertSee('Bad route!');
+    }
+
+    #[WithConfig('app.debug', false)]
+    public function testItCanRenderExceptionPageUsingSymfonyIfRendererIsNotDefined()
+    {
+        config(['app.debug' => true]);
+
+        $this->assertFalse($this->app->bound(Renderer::class));
+
+        $this->get('/failed')
+            ->assertInternalServerError()
+            ->assertSee('RuntimeException')
+            ->assertSee('Bad route!');
+    }
+}