Fix infinity loop on transaction committed

laravel · Jun 8, 2021 · 68ffc3d · 68ffc3d
1 parent 71a99f1
commit 68ffc3d
Showing 1 changed file with 5 additions and 8 deletions.
diff --git a/src/Illuminate/Database/DatabaseTransactionsManager.php b/src/Illuminate/Database/DatabaseTransactionsManager.php
@@ -58,15 +58,12 @@ public function rollback($connection, $level)
      */
     public function commit($connection)
     {
-        $this->transactions = $this->transactions->reject(function ($transaction) use ($connection) {
-            if ($transaction->connection == $connection) {
-                $transaction->executeCallbacks();
+        [$passes, $fails] = $this->transactions->partition(function ($transaction) use ($connection) {
+            return $transaction->connection == $connection;
+        });
 
-                return true;
-            }
-
-            return false;
-        })->values();
+        $this->transactions = $fails->values();
+        $passes->map->executeCallbacks();
     }
 
     /**