[11.x] Improve Queue::assertNothingPushed() error message (#51814)

* improve assertNothingPushed error message * Update QueueFake.php --------- Co-authored-by: Taylor Otwell <[email protected]>
laravel · Jun 17, 2024 · 534f0d3 · 534f0d3
1 parent ccdddaf
commit 534f0d3
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/src/Illuminate/Support/Testing/Fakes/QueueFake.php b/src/Illuminate/Support/Testing/Fakes/QueueFake.php
@@ -301,7 +301,9 @@ public function assertCount($expectedCount)
      */
     public function assertNothingPushed()
     {
-        PHPUnit::assertEmpty($this->jobs, 'Jobs were pushed unexpectedly.');
+        $pushedJobs = implode("\n- ", array_keys($this->jobs));
+
+        PHPUnit::assertEmpty($this->jobs, "The following jobs were pushed unexpectedly:\n\n- $pushedJobs\n");
     }
 
     /**

diff --git a/tests/Support/SupportTestingQueueFakeTest.php b/tests/Support/SupportTestingQueueFakeTest.php
@@ -5,6 +5,7 @@
 use BadMethodCallException;
 use Illuminate\Bus\Queueable;
 use Illuminate\Foundation\Application;
+use Illuminate\Queue\CallQueuedClosure;
 use Illuminate\Queue\QueueManager;
 use Illuminate\Support\Testing\Fakes\QueueFake;
 use Mockery as m;
@@ -194,11 +195,17 @@ public function testAssertNothingPushed()
 
         $this->fake->push($this->job);
 
+        $this->fake->push(function () {
+            //
+        });
+
         try {
             $this->fake->assertNothingPushed();
             $this->fail();
         } catch (ExpectationFailedException $e) {
-            $this->assertStringContainsString('Jobs were pushed unexpectedly.', $e->getMessage());
+            $this->assertStringContainsString('The following jobs were pushed unexpectedly', $e->getMessage());
+            $this->assertStringContainsString(get_class($this->job), $e->getMessage());
+            $this->assertStringContainsString(CallQueuedClosure::class, $e->getMessage());
         }
     }