Remove unused catch exception variables (#48209)

laravel · Aug 27, 2023 · 4c5d4d5 · 4c5d4d5
1 parent dda17ec
commit 4c5d4d5
Show file tree

Hide file tree

Showing 7 changed files with 9 additions and 9 deletions.
diff --git a/src/Illuminate/Bus/DatabaseBatchRepository.php b/src/Illuminate/Bus/DatabaseBatchRepository.php
@@ -342,7 +342,7 @@ protected function unserialize($serialized)
 
         try {
             return unserialize($serialized);
-        } catch (ModelNotFoundException $e) {
+        } catch (ModelNotFoundException) {
             return [];
         }
     }

diff --git a/src/Illuminate/Database/Eloquent/Builder.php b/src/Illuminate/Database/Eloquent/Builder.php
@@ -581,7 +581,7 @@ public function createOrFirst(array $attributes = [], array $values = [])
     {
         try {
             return $this->withSavepointIfNeeded(fn () => $this->create(array_merge($attributes, $values)));
-        } catch (UniqueConstraintViolationException $exception) {
+        } catch (UniqueConstraintViolationException) {
             return $this->useWritePdo()->where($attributes)->first();
         }
     }

diff --git a/src/Illuminate/Database/Eloquent/Relations/BelongsToMany.php b/src/Illuminate/Database/Eloquent/Relations/BelongsToMany.php
@@ -626,7 +626,7 @@ public function firstOrCreate(array $attributes = [], array $values = [], array
             } else {
                 try {
                     $this->getQuery()->withSavepointIfNeeded(fn () => $this->attach($instance, $joining, $touch));
-                } catch (UniqueConstraintViolationException $exception) {
+                } catch (UniqueConstraintViolationException) {
                     // Nothing to do, the model was already attached...
                 }
             }
@@ -656,7 +656,7 @@ public function createOrFirst(array $attributes = [], array $values = [], array
             return tap($this->related->where($attributes)->first(), function ($instance) use ($joining, $touch) {
                 $this->getQuery()->withSavepointIfNeeded(fn () => $this->attach($instance, $joining, $touch));
             });
-        } catch (UniqueConstraintViolationException $exception) {
+        } catch (UniqueConstraintViolationException) {
             return (clone $this)->useWritePdo()->where($attributes)->first();
         }
     }

diff --git a/src/Illuminate/Database/Eloquent/Relations/HasOneOrMany.php b/src/Illuminate/Database/Eloquent/Relations/HasOneOrMany.php
@@ -253,7 +253,7 @@ public function createOrFirst(array $attributes = [], array $values = [])
     {
         try {
             return $this->getQuery()->withSavepointIfNeeded(fn () => $this->create(array_merge($attributes, $values)));
-        } catch (UniqueConstraintViolationException $exception) {
+        } catch (UniqueConstraintViolationException) {
             return $this->useWritePdo()->where($attributes)->first();
         }
     }

diff --git a/src/Illuminate/Foundation/Exceptions/Handler.php b/src/Illuminate/Foundation/Exceptions/Handler.php
@@ -273,7 +273,7 @@ protected function reportThrowable(Throwable $e): void
 
         try {
             $logger = $this->container->make(LoggerInterface::class);
-        } catch (Exception $ex) {
+        } catch (Exception) {
             throw $e;
         }
 
@@ -370,7 +370,7 @@ protected function context()
             return array_filter([
                 'userId' => Auth::id(),
             ]);
-        } catch (Throwable $e) {
+        } catch (Throwable) {
             return [];
         }
     }

diff --git a/src/Illuminate/Routing/CompiledRouteCollection.php b/src/Illuminate/Routing/CompiledRouteCollection.php
@@ -121,7 +121,7 @@ public function match(Request $request)
             if ($result = $matcher->matchRequest($trimmedRequest)) {
                 $route = $this->getByName($result['_route']);
             }
-        } catch (ResourceNotFoundException|MethodNotAllowedException $e) {
+        } catch (ResourceNotFoundException|MethodNotAllowedException) {
             try {
                 return $this->routes->match($request);
             } catch (NotFoundHttpException) {

diff --git a/tests/Database/DatabaseEloquentIntegrationTest.php b/tests/Database/DatabaseEloquentIntegrationTest.php
@@ -1460,7 +1460,7 @@ public function testNestedTransactionsUsingSaveOrFailWillSucceed()
             try {
                 $user->email = '[email protected]';
                 $user->saveOrFail();
-            } catch (Exception $e) {
+            } catch (Exception) {
                 // ignore the exception
             }