Skip to content

Commit

Permalink
[5.5] Let Carbon be Macroable. (#19771)
Browse files Browse the repository at this point in the history
* Let Carbon be Macroable.

* Require nesbot/carbon in illuminate/support and remove it everywhere else.

* StyleCI fix.
  • Loading branch information
lucasmichot authored and taylorotwell committed Jun 28, 2017
1 parent bceded6 commit 282534f
Show file tree
Hide file tree
Showing 53 changed files with 149 additions and 84 deletions.
2 changes: 1 addition & 1 deletion src/Illuminate/Auth/Passwords/DatabaseTokenRepository.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@

namespace Illuminate\Auth\Passwords;

use Carbon\Carbon;
use Illuminate\Support\Str;
use Illuminate\Support\Carbon;
use Illuminate\Database\ConnectionInterface;
use Illuminate\Contracts\Hashing\Hasher as HasherContract;
use Illuminate\Contracts\Auth\CanResetPassword as CanResetPasswordContract;
Expand Down
3 changes: 1 addition & 2 deletions src/Illuminate/Auth/composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,7 @@
"illuminate/contracts": "5.5.*",
"illuminate/http": "5.5.*",
"illuminate/queue": "5.5.*",
"illuminate/support": "5.5.*",
"nesbot/carbon": "~1.20"
"illuminate/support": "5.5.*"
},
"autoload": {
"psr-4": {
Expand Down
2 changes: 1 addition & 1 deletion src/Illuminate/Cache/DatabaseStore.php
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

use Closure;
use Exception;
use Carbon\Carbon;
use Illuminate\Support\Carbon;
use Illuminate\Contracts\Cache\Store;
use Illuminate\Database\ConnectionInterface;

Expand Down
2 changes: 1 addition & 1 deletion src/Illuminate/Cache/FileStore.php
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
namespace Illuminate\Cache;

use Exception;
use Carbon\Carbon;
use Illuminate\Support\Arr;
use Illuminate\Support\Carbon;
use Illuminate\Contracts\Cache\Store;
use Illuminate\Filesystem\Filesystem;

Expand Down
2 changes: 1 addition & 1 deletion src/Illuminate/Cache/MemcachedStore.php
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
namespace Illuminate\Cache;

use Memcached;
use Carbon\Carbon;
use ReflectionMethod;
use Illuminate\Support\Carbon;
use Illuminate\Contracts\Cache\Store;
use Illuminate\Contracts\Cache\LockProvider;

Expand Down
2 changes: 1 addition & 1 deletion src/Illuminate/Cache/RateLimiter.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

namespace Illuminate\Cache;

use Carbon\Carbon;
use Illuminate\Support\Carbon;
use Illuminate\Contracts\Cache\Repository as Cache;

class RateLimiter
Expand Down
2 changes: 1 addition & 1 deletion src/Illuminate/Cache/Repository.php
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@
use Closure;
use DateTime;
use ArrayAccess;
use Carbon\Carbon;
use BadMethodCallException;
use Illuminate\Support\Carbon;
use Illuminate\Cache\Events\CacheHit;
use Illuminate\Contracts\Cache\Store;
use Illuminate\Cache\Events\KeyWritten;
Expand Down
3 changes: 1 addition & 2 deletions src/Illuminate/Cache/composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,7 @@
"require": {
"php": ">=7.0",
"illuminate/contracts": "5.5.*",
"illuminate/support": "5.5.*",
"nesbot/carbon": "~1.20"
"illuminate/support": "5.5.*"
},
"autoload": {
"psr-4": {
Expand Down
4 changes: 2 additions & 2 deletions src/Illuminate/Console/Scheduling/Event.php
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
namespace Illuminate\Console\Scheduling;

use Closure;
use Carbon\Carbon;
use Cron\CronExpression;
use Illuminate\Support\Carbon;
use GuzzleHttp\Client as HttpClient;
use Illuminate\Contracts\Mail\Mailer;
use Symfony\Component\Process\Process;
Expand Down Expand Up @@ -629,7 +629,7 @@ public function getSummaryForDisplay()
* @param \DateTime|string $currentTime
* @param int $nth
* @param bool $allowCurrentDate
* @return \Carbon\Carbon
* @return \Illuminate\Support\Carbon
*/
public function nextRunDate($currentTime = 'now', $nth = 0, $allowCurrentDate = false)
{
Expand Down
2 changes: 1 addition & 1 deletion src/Illuminate/Console/Scheduling/ManagesFrequencies.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

namespace Illuminate\Console\Scheduling;

use Carbon\Carbon;
use Illuminate\Support\Carbon;

trait ManagesFrequencies
{
Expand Down
1 change: 0 additions & 1 deletion src/Illuminate/Console/composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
"php": ">=7.0",
"illuminate/contracts": "5.5.*",
"illuminate/support": "5.5.*",
"nesbot/carbon": "~1.20",
"symfony/console": "~3.3"
},
"autoload": {
Expand Down
2 changes: 1 addition & 1 deletion src/Illuminate/Cookie/CookieJar.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@

namespace Illuminate\Cookie;

use Carbon\Carbon;
use Illuminate\Support\Arr;
use Illuminate\Support\Carbon;
use Symfony\Component\HttpFoundation\Cookie;
use Illuminate\Contracts\Cookie\QueueingFactory as JarContract;

Expand Down
6 changes: 3 additions & 3 deletions src/Illuminate/Database/Eloquent/Concerns/HasAttributes.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,11 @@

namespace Illuminate\Database\Eloquent\Concerns;

use Carbon\Carbon;
use LogicException;
use DateTimeInterface;
use Illuminate\Support\Arr;
use Illuminate\Support\Str;
use Illuminate\Support\Carbon;
use Illuminate\Contracts\Support\Arrayable;
use Illuminate\Database\Eloquent\Relations\Relation;
use Illuminate\Support\Collection as BaseCollection;
Expand Down Expand Up @@ -656,7 +656,7 @@ public function fromJson($value, $asObject = false)
* Return a timestamp as DateTime object with time set to 00:00:00.
*
* @param mixed $value
* @return \Carbon\Carbon
* @return \Illuminate\Support\Carbon
*/
protected function asDate($value)
{
Expand All @@ -667,7 +667,7 @@ protected function asDate($value)
* Return a timestamp as DateTime object.
*
* @param mixed $value
* @return \Carbon\Carbon
* @return \Illuminate\Support\Carbon
*/
protected function asDateTime($value)
{
Expand Down
4 changes: 2 additions & 2 deletions src/Illuminate/Database/Eloquent/Concerns/HasTimestamps.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

namespace Illuminate\Database\Eloquent\Concerns;

use Carbon\Carbon;
use Illuminate\Support\Carbon;

trait HasTimestamps
{
Expand Down Expand Up @@ -76,7 +76,7 @@ public function setUpdatedAt($value)
/**
* Get a fresh timestamp for the model.
*
* @return \Carbon\Carbon
* @return \Illuminate\Support\Carbon
*/
public function freshTimestamp()
{
Expand Down
3 changes: 1 addition & 2 deletions src/Illuminate/Database/composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,7 @@
"php": ">=7.0",
"illuminate/container": "5.5.*",
"illuminate/contracts": "5.5.*",
"illuminate/support": "5.5.*",
"nesbot/carbon": "~1.20"
"illuminate/support": "5.5.*"
},
"autoload": {
"psr-4": {
Expand Down
2 changes: 1 addition & 1 deletion src/Illuminate/Foundation/Console/DownCommand.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

namespace Illuminate\Foundation\Console;

use Carbon\Carbon;
use Illuminate\Support\Carbon;
use Illuminate\Console\Command;

class DownCommand extends Command
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,15 +3,15 @@
namespace Illuminate\Foundation\Http\Exceptions;

use Exception;
use Carbon\Carbon;
use Illuminate\Support\Carbon;
use Symfony\Component\HttpKernel\Exception\ServiceUnavailableHttpException;

class MaintenanceModeException extends ServiceUnavailableHttpException
{
/**
* When the application was put in maintenance mode.
*
* @var \Carbon\Carbon
* @var \Illuminate\Support\Carbon
*/
public $wentDownAt;

Expand All @@ -25,7 +25,7 @@ class MaintenanceModeException extends ServiceUnavailableHttpException
/**
* When the application should next be available.
*
* @var \Carbon\Carbon
* @var \Illuminate\Support\Carbon
*/
public $willBeAvailableAt;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
namespace Illuminate\Foundation\Http\Middleware;

use Closure;
use Carbon\Carbon;
use Illuminate\Support\Carbon;
use Illuminate\Foundation\Application;
use Symfony\Component\HttpFoundation\Cookie;
use Illuminate\Contracts\Encryption\Encrypter;
Expand Down
2 changes: 1 addition & 1 deletion src/Illuminate/Notifications/Messages/SlackAttachment.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

namespace Illuminate\Notifications\Messages;

use Carbon\Carbon;
use Illuminate\Support\Carbon;

class SlackAttachment
{
Expand Down
2 changes: 1 addition & 1 deletion src/Illuminate/Queue/Console/RestartCommand.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

namespace Illuminate\Queue\Console;

use Carbon\Carbon;
use Illuminate\Support\Carbon;
use Illuminate\Console\Command;

class RestartCommand extends Command
Expand Down
2 changes: 1 addition & 1 deletion src/Illuminate/Queue/Console/WorkCommand.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@

namespace Illuminate\Queue\Console;

use Carbon\Carbon;
use Illuminate\Queue\Worker;
use Illuminate\Support\Carbon;
use Illuminate\Console\Command;
use Illuminate\Contracts\Queue\Job;
use Illuminate\Queue\WorkerOptions;
Expand Down
2 changes: 1 addition & 1 deletion src/Illuminate/Queue/DatabaseQueue.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

namespace Illuminate\Queue;

use Carbon\Carbon;
use Illuminate\Support\Carbon;
use Illuminate\Database\Connection;
use Illuminate\Queue\Jobs\DatabaseJob;
use Illuminate\Queue\Jobs\DatabaseJobRecord;
Expand Down
2 changes: 1 addition & 1 deletion src/Illuminate/Queue/Failed/DatabaseFailedJobProvider.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

namespace Illuminate\Queue\Failed;

use Carbon\Carbon;
use Illuminate\Support\Carbon;
use Illuminate\Database\ConnectionResolverInterface;

class DatabaseFailedJobProvider implements FailedJobProviderInterface
Expand Down
2 changes: 1 addition & 1 deletion src/Illuminate/Queue/InteractsWithTime.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@

namespace Illuminate\Queue;

use Carbon\Carbon;
use DateTimeInterface;
use Illuminate\Support\Carbon;

trait InteractsWithTime
{
Expand Down
1 change: 0 additions & 1 deletion src/Illuminate/Queue/composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@
"illuminate/database": "5.5.*",
"illuminate/filesystem": "5.5.*",
"illuminate/support": "5.5.*",
"nesbot/carbon": "~1.20",
"symfony/debug": "~3.3",
"symfony/process": "~3.3"
},
Expand Down
2 changes: 1 addition & 1 deletion src/Illuminate/Routing/Middleware/ThrottleRequests.php
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
namespace Illuminate\Routing\Middleware;

use Closure;
use Carbon\Carbon;
use Illuminate\Support\Carbon;
use Illuminate\Cache\RateLimiter;
use Symfony\Component\HttpFoundation\Response;

Expand Down
2 changes: 1 addition & 1 deletion src/Illuminate/Session/CookieSessionHandler.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@

namespace Illuminate\Session;

use Carbon\Carbon;
use SessionHandlerInterface;
use Illuminate\Support\Carbon;
use Symfony\Component\HttpFoundation\Request;
use Illuminate\Contracts\Cookie\QueueingFactory as CookieJar;

Expand Down
2 changes: 1 addition & 1 deletion src/Illuminate/Session/DatabaseSessionHandler.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@

namespace Illuminate\Session;

use Carbon\Carbon;
use Illuminate\Support\Arr;
use SessionHandlerInterface;
use Illuminate\Support\Carbon;
use Illuminate\Contracts\Auth\Guard;
use Illuminate\Database\QueryException;
use Illuminate\Database\ConnectionInterface;
Expand Down
2 changes: 1 addition & 1 deletion src/Illuminate/Session/FileSessionHandler.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@

namespace Illuminate\Session;

use Carbon\Carbon;
use SessionHandlerInterface;
use Illuminate\Support\Carbon;
use Symfony\Component\Finder\Finder;
use Illuminate\Filesystem\Filesystem;

Expand Down
2 changes: 1 addition & 1 deletion src/Illuminate/Session/Middleware/StartSession.php
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@
namespace Illuminate\Session\Middleware;

use Closure;
use Carbon\Carbon;
use Illuminate\Support\Arr;
use Illuminate\Http\Request;
use Illuminate\Support\Carbon;
use Illuminate\Session\SessionManager;
use Illuminate\Contracts\Session\Session;
use Illuminate\Session\CookieSessionHandler;
Expand Down
1 change: 0 additions & 1 deletion src/Illuminate/Session/composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
"illuminate/contracts": "5.5.*",
"illuminate/filesystem": "5.5.*",
"illuminate/support": "5.5.*",
"nesbot/carbon": "~1.20",
"symfony/finder": "~3.3",
"symfony/http-foundation": "~3.3"
},
Expand Down
11 changes: 11 additions & 0 deletions src/Illuminate/Support/Carbon.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
<?php

namespace Illuminate\Support;

use Carbon\Carbon as BaseCarbon;
use Illuminate\Support\Traits\Macroable;

class Carbon extends BaseCarbon
{
use Macroable;
}
3 changes: 2 additions & 1 deletion src/Illuminate/Support/composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,8 @@
"php": ">=7.0",
"ext-mbstring": "*",
"doctrine/inflector": "~1.0",
"illuminate/contracts": "5.5.*"
"illuminate/contracts": "5.5.*",
"nesbot/carbon": "^1.20"
},
"replace": {
"tightenco/collect": "self.version"
Expand Down
2 changes: 1 addition & 1 deletion tests/Auth/AuthDatabaseTokenRepositoryTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
namespace Illuminate\Tests\Auth;

use Mockery as m;
use Carbon\Carbon;
use Illuminate\Support\Carbon;
use PHPUnit\Framework\TestCase;
use Illuminate\Auth\Passwords\DatabaseTokenRepository;

Expand Down
2 changes: 1 addition & 1 deletion tests/Cache/CacheFileStoreTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

namespace Illuminate\Tests\Cache;

use Carbon\Carbon;
use Illuminate\Support\Carbon;
use Illuminate\Cache\FileStore;
use PHPUnit\Framework\TestCase;
use Illuminate\Contracts\Filesystem\FileNotFoundException;
Expand Down
Loading

0 comments on commit 282534f

Please sign in to comment.