-
Notifications
You must be signed in to change notification settings - Fork 11.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
1 parent
1cdace4
commit 108f015
Showing
1 changed file
with
2 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@taylorotwell hardcoding
__CLASS__
here, breaks backwards compatibility.We're migrating from Laravel 9.x. We have an MyEvent which inherits from
BroadcastNotificationCreated
. After this change we getBroadcastNotificationCreated
as event name instead ofMyEvent
which was calculated in Laravel 9.x.According to my understanding, before #48136 the code that was providing the name sits here: https://github.com/laravel/framework/blob/10.x/src/Illuminate/Broadcasting/BroadcastEvent.php#L76-L77 so using
get_class($this)
should solve backwards incompatibility problem.What do you think? Should I create a PR?