[6.x] Fix logout() when using AuthenticateSession middleware
#826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driesvints
changed the title
logout() when using AuthenticateSession middlewarelogout() when using AuthenticateSession middleware
|
We don't support two the same browser calls in the same test method. Dusk is meant to mimic a real life scenario and you only do one single request when navigating to a page and running assertions. |
|
@driesvints we don't? |
|
@taylorotwell calling HTTP requests twice in the same test method has always lead to edge cases and problems afaik. |
|
FYI: this wasn't related to double HTTP calls in the end. |
murrant
added a commit
to murrant/dusk
that referenced
this pull request
Oct 17, 2021
Fix was attempted by laravel#826, but the string concatenation is wrong and it never uses the default guard.
murrant
added a commit
to murrant/dusk
that referenced
this pull request
Oct 17, 2021
Fix was attempted by laravel#826, but the string concatenation is wrong and it never uses the default guard.
murrant
added a commit
to murrant/dusk
that referenced
this pull request
Oct 17, 2021
Fix was attempted by laravel#826, but the string concatenation is wrong and it never uses the default guard.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #825