Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.0.13] Let jQuery handle string selector #228

Merged
merged 1 commit into from
Apr 19, 2017

Conversation

deleugpn
Copy link
Contributor

Closes #56

    public function testBasicExample() {
        $this->browse(function (Browser $browser) {
            $browser->visit('/')
                ->assertSee('Laravel')
                ->clickLink('Laravel\'s Documentation');
        });
    }

@taylorotwell
Copy link
Member

Did you test that this works?

@deleugpn
Copy link
Contributor Author

Yes.

class ExampleTest extends DuskTestCase {
    /**
     * A basic browser test example.
     *
     * @return void
     */
    public function testBasicExample() {
        $this->browse(function (Browser $browser) {
            $browser->visit('/')
                ->assertSee('Laravel')
                ->clickLink('Laravel\'s Documentation')
                ->screenshot('with-quote');
        });
    }

    public function testBasicExample2() {
        $this->browse(function (Browser $browser) {
            $browser->visit('/')
                ->assertSee('Laravel')
                ->clickLink('Laracasts')
                ->screenshot('without-quote');
        });
    }
}

welcome.blade.php

<div class="links">
        <a href="https://laravel.com/docs">Laravel's Documentation</a>
        <a href="https://laracasts.com">Laracasts</a>
        <a href="https://laravel-news.com">News</a>
        <a href="https://forge.laravel.com">Forge</a>
        <a href="https://github.com/laravel/laravel">GitHub</a>
</div>

With Single Quote
With Quotes

Without (backward compatible)
Without Quotes

@deleugpn deleugpn changed the title Let jQuery handle string selector [1.0.13] Let jQuery handle string selector Apr 19, 2017
@taylorotwell taylorotwell merged commit 39e4f84 into laravel:master Apr 19, 2017
@deleugpn deleugpn deleted the single-quotes-on-links branch April 19, 2017 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants