Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removed Laravel\Dusk\Page import from dusk:page stub #1145

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

fxnm
Copy link
Contributor

@fxnm fxnm commented Oct 20, 2024

Changes

  • Fixes the generated pages using php artisan dusk:page PageName to not use Laravel\Dusk\Page.
    Because with the install command php artisan dusk:install a abstract class Pagewas created in Tests\Browser\Pages and should be used instead.

Reason

@taylorotwell taylorotwell merged commit 983368a into laravel:8.x Oct 21, 2024
19 checks passed
crynobone added a commit that referenced this pull request Oct 22, 2024
…\Dusk\Page` via `dusk:page` command

Improvements based on #1145

Signed-off-by: Mior Muhammad Zaki <[email protected]>
taylorotwell pushed a commit that referenced this pull request Oct 22, 2024
…\Dusk\Page` via `dusk:page` command (#1148)

Improvements based on #1145

Signed-off-by: Mior Muhammad Zaki <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants