Move hasHeadlessDisabled() and shouldStartMaximized() to Laravel\Dusk\TestCase
#1098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@crynobone tests fail here |
crynobone
changed the title
hasHeadlessDisabled() and shouldStartMaximized() tohasHeadlessDisabled() and shouldStartMaximized() to Laravel\Dusk\TestCase
`Laravel\Dusk\TestCase`. We don't typically change this configuration. It shouldn't be in the stubs file. Signed-off-by: Mior Muhammad Zaki <[email protected]>
crynobone
force-pushed
the
simplify-stubs
branch
from
a2854c2 to
224cac5
Compare
derekmd
added a commit
to derekmd/laravel-dusk-firefox
that referenced
this pull request
Oct 20, 2024
laravel/dusk#1098 Laravel Dusk 8.x now defines these methods in class Laravel\Dusk\TestCase so the stub classes that extend TestCase don't need to redefine hasHeadlessDisabled() and shouldStartMaximized().
derekmd
added a commit
to derekmd/laravel-dusk-firefox
that referenced
this pull request
Oct 20, 2024
laravel/dusk#1098 Laravel Dusk 8.x now defines these methods in class Laravel\Dusk\TestCase so the stub classes that extend TestCase don't need to redefine hasHeadlessDisabled() and shouldStartMaximized().
derekmd
added a commit
to derekmd/laravel-dusk-firefox
that referenced
this pull request
Oct 20, 2024
laravel/dusk#1098 Laravel Dusk 8.x now defines these methods in class Laravel\Dusk\TestCase so the stub classes that extend TestCase don't need to redefine hasHeadlessDisabled() and shouldStartMaximized().
derekmd
added a commit
to derekmd/laravel-dusk-firefox
that referenced
this pull request
Oct 20, 2024
laravel/dusk#1098 Laravel Dusk 8.x now defines these methods in class Laravel\Dusk\TestCase so the stub classes that extend TestCase don't need to redefine hasHeadlessDisabled() and shouldStartMaximized().
derekmd
added a commit
to derekmd/laravel-dusk-firefox
that referenced
this pull request
Oct 20, 2024
laravel/dusk#1098 Laravel Dusk 8.x now defines these methods in class Laravel\Dusk\TestCase so the stub classes that extend TestCase don't need to redefine hasHeadlessDisabled() and shouldStartMaximized().
derekmd
added a commit
to derekmd/laravel-dusk-firefox
that referenced
this pull request
Oct 20, 2024
laravel/dusk#1098 Laravel Dusk 8.x now defines these methods in class Laravel\Dusk\TestCase so the stub classes that extend TestCase don't need to redefine hasHeadlessDisabled() and shouldStartMaximized().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't typically change this configuration. It shouldn't be in the stubs file.