Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix favicon 404s triggered when using loginAs() or logout() methods #1061

Merged
merged 2 commits into from
Sep 26, 2023
Merged

Fix favicon 404s triggered when using loginAs() or logout() methods #1061

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b09c99a
return 204 no content
ziadoz Sep 26, 2023
40efdc0
docblocks
ziadoz Sep 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/Http/Controllers/UserController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ public function user($guard = null)
*
* @param string $userId
* @param string|null $guard
* @return void
* @return \Illuminate\Http\Response
*/
public function login($userId, $guard = null)
{
Expand All @@ -46,13 +46,15 @@ public function login($userId, $guard = null)
: $provider->retrieveById($userId);

Auth::guard($guard)->login($user);

return response(status: 204);
}

/**
* Log the user out of the application.
*
* @param string|null $guard
* @return void
* @return \Illuminate\Http\Response
*/
public function logout($guard = null)
{
Expand All @@ -61,6 +63,8 @@ public function logout($guard = null)
Auth::guard($guard)->logout();

Session::forget('password_hash_'.$guard);

return response(status: 204);
}

/**
Expand Down