Skip to content

Commit

Permalink
Fix favicon 404s triggered when using loginAs() or logout() methods (#…
Browse files Browse the repository at this point in the history
…1061)

* return 204 no content

* docblocks
  • Loading branch information
ziadoz authored Sep 26, 2023
1 parent 675e336 commit 076865d
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions src/Http/Controllers/UserController.php
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ public function user($guard = null)
*
* @param string $userId
* @param string|null $guard
* @return void
* @return \Illuminate\Http\Response
*/
public function login($userId, $guard = null)
{
Expand All @@ -46,13 +46,15 @@ public function login($userId, $guard = null)
: $provider->retrieveById($userId);

Auth::guard($guard)->login($user);

return response(status: 204);
}

/**
* Log the user out of the application.
*
* @param string|null $guard
* @return void
* @return \Illuminate\Http\Response
*/
public function logout($guard = null)
{
Expand All @@ -61,6 +63,8 @@ public function logout($guard = null)
Auth::guard($guard)->logout();

Session::forget('password_hash_'.$guard);

return response(status: 204);
}

/**
Expand Down

0 comments on commit 076865d

Please sign in to comment.