Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vite.md #8024

Closed
wants to merge 1 commit into from
Closed

Update vite.md #8024

wants to merge 1 commit into from

Conversation

shealan
Copy link

@shealan shealan commented Jul 5, 2022

Added additional information on customising the SSR file output directory. This should help Envoyer users from getting stung by this potential gotcha.

Added additional information on customising the SSR file output directory. This should help Envoyer users from getting stung by this potential gotcha.
@jessarcher
Copy link
Member

jessarcher commented Jul 6, 2022

Thanks, @shealan. I'm trying to think if there's a different location we can place it by default rather than needing extra documentation.

I'm worried that placing it in the public directory opens a potential security concern as this file is a server and not something for browsers to download.

I'm thinking bootstrap/ssr/ssr.js is a contender as Laravel already uses the bootstrap directory for storing files generated at build-time (as opposed to files generated at run time like in storage)

@shealan
Copy link
Author

shealan commented Jul 6, 2022

@jessarcher yes I think/bootstrap/ssr/ssr.js makes a lot of sense.

@taylorotwell
Copy link
Member

@jessarcher yeah, I would prefer to just move this file now so it works well with our first-party tools.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants