Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] Update cache.md #6598

Closed
wants to merge 1 commit into from

Conversation

raftx24
Copy link

@raftx24 raftx24 commented Nov 27, 2020

This PR addresses a potential problem when using as default a custom cache driver.
By registering drivers in the boot method of an ApplicationServiceProvider as currently recommended in the docs, the driver may not available to other services that need retrieving values from cache, services that run in boot methods from other service providers. This can happen due to load order of the providers.

updates custom cache
@raftx24 raftx24 changed the title Update cache.md [8.x] Update cache.md Nov 27, 2020
@driesvints
Copy link
Member

FYI, @taylorotwell, this is related to laravel/telescope#988. I'm not sure that this is the best place to document it but I agree with @raftx24 & @aocneanu that we should update the docs here a little.

@taylorotwell
Copy link
Member

I've made these changes on my local branch that I'm about to send up to laravel/docs next week. Thanks.

jasonvarga added a commit to statamic/cms that referenced this pull request Dec 16, 2020
jasonvarga added a commit to statamic/cms that referenced this pull request Dec 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants