[5.7] Correct Mail set locale code snippet #4875
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: laravel/framework#27023
The documented mailable localization example:
would always be sent using the default locale since
PendingMail@fill()
overrides 'es' with thePendingMail
default value which isnull
.Mail::to($request->user())->locale('es')
should instead be used to set the locale through the mail service.There may have been confusion since laravel/framework#25752 started allowing this call for a
Notification
:since there is no intermediate object to assign a locale to.