[5.7] PSR-11 container #4579
[5.7] PSR-11 container #4579
Conversation
| @@ -276,4 +276,4 @@ Laravel's service container implements the [PSR-11](https://github.com/php-fig/f | |||
| // | |||
| }); | |||
|
|
|||
| > {note} Calling the `get` method will throw an exception if the identifier has not been explicitly bound into the container. | |||
| If the identifier cannot be resolved an exception is thrown. The exception will be `Psr\Container\NotFoundExceptionInterface` if the identifier was never bound or a `Psr\Container\ContainerExceptionInterface` otherwise. | |||
There was a problem hiding this comment.
I feel like this needs some rewording. What do you think of this?
If the identifier cannot be resolved, a
Psr\Container\NotFoundExceptionInterfaceis thrown. Otherwise, if the identifier was never bound, aPsr\Container\ContainerExceptionInterfaceis thrown instead.
There was a problem hiding this comment.
When you say Otherwise after If the identifier cannot be resolved, I imagine it's talking about if the identifier can be resolved, which is actually false. Furthermore, stating that a Psr\Container\NotfoundExceptionInterface is thrown if the identifier cannot be resolved is false because it depends on whether the identifier was bound or not. The second part of the statement is also wrong as Psr\Container\ContainerExceptionInterface is thrown if the identifier was bound and not resolved.
There was a problem hiding this comment.
Ah, I completely misread the original text! Ignore me 😄
Docs for laravel/framework#25870 in case we choose this path.