[5.5] Update HasManyThrough Documentation #3306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the documentation for `HasManyThrough` relations to clarify how the different keys are used, and to document the addition of laravel/framework#19114. I'm not quite happy with the (in my opinion) too technical wording of the explaining paragraph, so I will gladly accept proposals for change.
|
Wait, so the last argument is for the intermediate table? That's kind of annoying because now the argument order goes... (model, model, intermediate, final, final, intermediate)... it should be model, model, intermediate, final, intermediate, final. |
|
Yes. We can revert the previous one, and I'll re-PR, or I can submit a patch if you want that changed. The reason for it was to minimise breaking changes. Right now, the only BC break is in the |
|
I think it's OK. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the documentation for
HasManyThroughrelations to clarify how the different keys are used, and to document the addition of laravel/framework#19114.I'm not quite happy with the (in my opinion) too technical wording of the explaining paragraph, so I will gladly accept proposals for change.