[9.0] Don't try and find a user when stripeId is null #721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a payment is manually created from the Stripe dashboard, it is possible that it will not be linked to a customer. When this null stripeId is used to find a user record, it will find the first customer record that does not have a stripeId in the database. Adding an early exit will prevent this from happening, and stop these null stripeId users being erroneously referenced in webhook handling.
driesvints
changed the title
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a payment is manually created from the Stripe dashboard, it is
possible that it will not be linked to a customer.
When this null stripeId is used to find a user record, it will find the
first customer record that does not have a stripeId in the database.
Adding an early exit will prevent this from happening, and stop these
null stripeId users being erroneously referenced in webhook handling.