Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13.x] Payment page updates #1120

Merged
merged 19 commits into from
May 31, 2021
Merged

[13.x] Payment page updates #1120

merged 19 commits into from
May 31, 2021

Conversation

driesvints
Copy link
Member

@driesvints driesvints commented Apr 9, 2021

This PR refactors the payment page and will provide full support for the SEPA debit payment method as well as other payment methods. It now features a select dropdown when there's more than one payment method type available on the payment intent. The correct Stripe elements will be rendered for each one and if the payment method requires a redirect that'll also be handled properly. The PR also comes with support for saving payment methods (the ones that can do that) to the customer.

I didn't implement support for every single payment method but instead focused on the ones that seemed important enough:

  • Credit Cards
  • Alipay
  • Bancontact
  • BECS Direct Debit
  • EPS
  • Giropay
  • iDEAL
  • SEPA Direct Debit

Todo:

Screenshot 2021-05-25 at 18 07 18

Closes #435 #1132

@driesvints driesvints force-pushed the payment-page-updates branch from a08ea18 to 6b5c200 Compare April 27, 2021 13:28
@driesvints driesvints force-pushed the payment-page-updates branch 2 times, most recently from cdbf7f5 to 7e3a1a9 Compare May 20, 2021 16:21
@driesvints driesvints force-pushed the payment-page-updates branch from e64263d to 9fc66ae Compare May 25, 2021 16:15
@driesvints driesvints requested a review from claudiodekker May 25, 2021 16:15
@driesvints driesvints marked this pull request as ready for review May 27, 2021 14:47
@driesvints driesvints requested a review from taylorotwell May 27, 2021 16:10
@taylorotwell taylorotwell merged commit ac99c86 into master May 31, 2021
@taylorotwell taylorotwell deleted the payment-page-updates branch May 31, 2021 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants