-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[13.x] Payment page updates #1120
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driesvints
force-pushed
the
payment-page-updates
branch
from
April 27, 2021 13:28
a08ea18
to
6b5c200
Compare
driesvints
force-pushed
the
payment-page-updates
branch
2 times, most recently
from
May 20, 2021 16:21
cdbf7f5
to
7e3a1a9
Compare
driesvints
force-pushed
the
payment-page-updates
branch
from
May 25, 2021 16:15
e64263d
to
9fc66ae
Compare
claudiodekker
approved these changes
May 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the payment page and will provide full support for the SEPA debit payment method as well as other payment methods. It now features a select dropdown when there's more than one payment method type available on the payment intent. The correct Stripe elements will be rendered for each one and if the payment method requires a redirect that'll also be handled properly. The PR also comes with support for saving payment methods (the ones that can do that) to the customer.
I didn't implement support for every single payment method but instead focused on the ones that seemed important enough:
Todo:
payment_method_types
valuesCloses #435 #1132