Add support for Phar builds on Windows #389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nunomaduro
approved these changes
Mar 13, 2020
owenvoke
added a commit
that referenced
this pull request
Mar 13, 2020
Add support for Phar builds on Windows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to @shadoWalker89 for the initial work on this with v6 of Laravel Zero (#348).
This adds support for building single-file Phar applications on Windows. Tested in Git Bash, PowerShell, and CMD. Linux Subsystem for Windows (which uses the normal
./boxbinary as expected) does not function correctly when I've tested due to box-project/box#437, but this is due to not being able to change theulimiton WSL2.I've enforced using the local
boxbinary by using.\box.baton Windows. This prevents the use of a globally installed Box instance.However, note that Box doesn't officially support Windows yet so the actual compilation may fail in some cases.
Preview Windows build output
Closes #348