Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repeated import of the FQCN when running facade-alias #6

Closed
ndeblauw opened this issue Sep 26, 2023 · 9 comments
Closed

Repeated import of the FQCN when running facade-alias #6

ndeblauw opened this issue Sep 26, 2023 · 9 comments

Comments

@ndeblauw
Copy link

When running the facade-aliases task, if a Global Facade is used multiple times, the import at the top (use statement) is repeated for every detected Facade

image

@jasonmccreary
Copy link
Collaborator

This should be resolved in #4. What version of the CLI are you running? (shift-cli --version)

@ndeblauw
Copy link
Author

ndeblauw commented Sep 26, 2023

I'm running Shift CLI 0.2.5, which is the version that got installed when I did composer require earlier today

@jasonmccreary
Copy link
Collaborator

Please update to 0.2.7 and see if the issue is resolved.

@ndeblauw
Copy link
Author

Somehow it is not possible for me to upgrade to a version higher than 0.2.5, not even when I write it manually in my composer.json. Testing on a Laravel9 (on php 8.1.10) installation
image

@relaypilot
Copy link

@ndeblauw laravel-shift/cli is at version 0.2.7, but you're using the laravel-shift/cli-premium which is still at 0.2.5 - maybe the fix was not applied to the premium package yet (I'm having the same issue as you)

@jasonmccreary
Copy link
Collaborator

Yes, I just retagged the laravel-shift/cli-premium package. Please run composer update and see if it resolves the problem.

@relaypilot
Copy link

Nothing to install, update or remove

I'm still at "laravel-shift/cli-premium": "^0.2.5", after running composer update

@jasonmccreary
Copy link
Collaborator

Sorry, I just pushed it. Please try again.

@ndeblauw
Copy link
Author

ndeblauw commented Oct 6, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants