Resolved issue #12 #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhaoda
requested changes
Dec 11, 2017
README.md
Outdated
| ``` | ||
| 'smscru' => [ | ||
| ... | ||
| 'host' => 'http://www1.smsc.kz/', |
README.md
Outdated
| @@ -57,6 +57,15 @@ Add your SmscRu login, secret key (hashed password) and default sender name (or | |||
| ... | |||
| ``` | |||
|
|
|||
| > If smsc.ru is not responding, you can set custom host WITH trailing slash | |||
There was a problem hiding this comment.
Не очень понятно, можно подумать, что пакет автоматом переключится на этот хост, если основной не отвечает.
src/SmscRuApi.php
Outdated
| @@ -25,11 +25,12 @@ class SmscRuApi | |||
| /** @var string */ | |||
| protected $sender; | |||
|
|
|||
| public function __construct($login, $secret, $sender) | |||
| public function __construct($config) | |||
src/SmscRuApi.php
Outdated
| $this->login = $login; | ||
| $this->secret = $secret; | ||
| $this->sender = $sender; | ||
| $this->url = array_get($config, 'host', 'https://smsc.ru/').'sys/send.php'; |
|
merge plz! |
jhaoda
approved these changes
Mar 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
! merge with squash, please