Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add method to set the template_id of the message #77

Conversation

dyegonery
Copy link

Add a method to set the template_id of the message

/**
* Set the message template_id
*
* @param string $valye
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, little typo here 😅 value instead of valye

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol. Thanks @Lloople

Remove any contents set by the constructor when using the `setTemplate()` method.
@dyegonery
Copy link
Author

Actually, I just tested the package on this branch, and this PR ir still needed in order to allow messages to be sent using a template. It's because the contents is generated by the constructor of OneSignalMessage.

@LKaemmerling
Copy link
Collaborator

Looks okay for me :) I merge it. Thank you!

@LKaemmerling LKaemmerling merged commit b1e9d1b into laravel-notification-channels:refactor-to-traits Aug 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants