Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ability of user to send notification , filtering for multiple tags #73

Conversation

rylxes
Copy link

@rylxes rylxes commented Jul 5, 2018

the current notification sending by tags filtering

public function routeNotificationForOneSignal() { return ['tags' => ['key' => 'device_uuid', 'relation' => '=', 'value' => '123e4567-e89b-12d3-a456-426655440000']]; }

Ability to filter by more than one tag i.e
public function routeNotificationForOneSignal() { return ['tags' => [ ['key' => 'device_uuid', 'relation' => '=', 'value' => '123e4567-e89b-12d3-a456-426655440000'], ['key' => 'role', 'relation' => '=', 'value' => 'admin'] ] ]; }

@rylxes
Copy link
Author

rylxes commented Jul 5, 2018

#71

@LKaemmerling
Copy link
Collaborator

Could you please rebase this on the refactor-to-traits branch?

@rylxes
Copy link
Author

rylxes commented Jul 5, 2018

I have done that, ... the current branch is up to date

@LKaemmerling
Copy link
Collaborator

For me this looks okay @Lloople what do you think?

@LKaemmerling LKaemmerling merged commit 83c1c00 into laravel-notification-channels:refactor-to-traits Aug 16, 2018
@rylxes rylxes deleted the send_to_multiple_tags branch August 16, 2018 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants