Send Notification based on the E-Mail instead of the OneSignal User ID #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After a little Chat with the OneSignal Team, it isn't possible to use the filter with more than one "email" filter.
|
Travis fails because of an error from packagist, looks like they had a temporary issue. (because the test fails on only one php version) |
Lloople
previously requested changes
Jan 4, 2018
tests/NotifiableEMail.php
Outdated
|
|
||
| namespace NotificationChannels\OneSignal\Test; | ||
|
|
||
| class NotifiableEMail |
There was a problem hiding this comment.
Should this class be named NotifiableEmail instead of NotifiableEMai? 🤔
Lloople
approved these changes
Jan 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As wished from many parts and needed by myself, hear it comes.
After this PR it is possible to send a Notification Based on the User E-Mail.(https://documentation.onesignal.com/docs/email-syncing-and-targeting)
To use this feature, you must sync the E-Mail first with OneSignal and than change the Method "routeNotificationForOneSignal()" on your notifiable Model to something like this:
Because of the new index 'email' the package knows that it should use the email filter instead of the OneSignalUserId.
Actually it isn't possible to use an array with multiple E-Mails, because of a limitation from the OneSignal Api.
This PR keeps the BC and doesn't require a change to existing installations of the package.